Messages in this thread | | | From | Amir Goldstein <> | Date | Tue, 27 Jun 2023 09:20:09 +0300 | Subject | Re: [PATCH v2 3/3] splice: fsnotify_access(in), fsnotify_modify(out) on success in tee |
| |
On Tue, Jun 27, 2023 at 2:09 AM Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz> wrote: > > Same logic applies here: this can fill up the pipe, and pollers that rely > on getting IN_MODIFY notifications never wake up. > > Fixes: 983652c69199 ("splice: report related fsnotify events") > Link: https://lore.kernel.org/linux-fsdevel/jbyihkyk5dtaohdwjyivambb2gffyjs3dodpofafnkkunxq7bu@jngkdxx65pux/t/#u > Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Makes sense.
Reviewed-by: Amir Goldstein <amir73il@gmail.com>
> --- > fs/splice.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/fs/splice.c b/fs/splice.c > index a18274209dc1..3234aaa6e957 100644 > --- a/fs/splice.c > +++ b/fs/splice.c > @@ -1819,6 +1819,11 @@ long do_tee(struct file *in, struct file *out, size_t len, unsigned int flags) > } > } > > + if (ret > 0) { > + fsnotify_access(in); > + fsnotify_modify(out); > + } > + > return ret; > } > > -- > 2.39.2
| |