lkml.org 
[lkml]   [2023]   [Jun]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH v2 2/3] splice: fsnotify_modify(fd) in vmsplice
    Same logic applies here: this can fill up the pipe and pollers that rely
    on getting IN_MODIFY notifications never wake up.

    Fixes: 983652c69199 ("splice: report related fsnotify events")
    Link: https://lore.kernel.org/linux-fsdevel/jbyihkyk5dtaohdwjyivambb2gffyjs3dodpofafnkkunxq7bu@jngkdxx65pux/t/#u
    Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
    ---
    fs/splice.c | 3 +++
    1 file changed, 3 insertions(+)

    diff --git a/fs/splice.c b/fs/splice.c
    index 94fae24f9d54..a18274209dc1 100644
    --- a/fs/splice.c
    +++ b/fs/splice.c
    @@ -1447,6 +1447,9 @@ SYSCALL_DEFINE4(vmsplice, int, fd, const struct iovec __user *, uiov,
    else
    error = vmsplice_to_user(f.file, &iter, flags);

    + if (error > 0)
    + fsnotify_modify(f.file);
    +
    kfree(iov);
    out_fdput:
    fdput(f);
    --
    2.39.2
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2023-06-27 01:11    [W:4.149 / U:0.088 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site