lkml.org 
[lkml]   [2023]   [Jun]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Subject[PATCH -next 0/2] md/raid5-cache: fix a deadlock in r5l_exit_log()
Date
From: Yu Kuai <yukuai3@huawei.com>

Commit b13015af94cf ("md/raid5-cache: Clear conf->log after finishing
work") introduce a new problem:

// caller hold reconfig_mutex
r5l_exit_log
flush_work(&log->disable_writeback_work)
r5c_disable_writeback_async
wait_event
/*
* conf->log is not NULL, and mddev_trylock()
* will fail, wait_event() can never pass.
*/
conf->log = NULL

patch 1 revert this patch, an patch 2 fix the original problem in a
different way.

Noted this problem is just found by code review, and I think this is
probably the reason that some mdadm tests is broken.

Yu Kuai (2):
md/raid5-cache: Revert "md/raid5-cache: Clear conf->log after
finishing work"
md/raid5-cache: fix null-ptr-deref in r5l_reclaim_thread()

drivers/md/raid5-cache.c | 24 ++++++++++--------------
1 file changed, 10 insertions(+), 14 deletions(-)

--
2.39.2

\
 
 \ /
  Last update: 2023-06-27 10:58    [W:0.208 / U:0.152 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site