Messages in this thread Patch in this message | | | From | Chungkai Yang <> | Subject | [PATCH v2] PM: QoS: Restore support for default value on frequency QoS | Date | Tue, 27 Jun 2023 15:17:27 +0800 |
| |
PM_QOS_DEFAULT_VALUE case is not covered.
Commit 8d36694245f2 ("PM: QoS: Add check to make sure CPU freq is non-negative") makes sure CPU freq is non-negative to avoid negative value converting to unsigned data type. However, when the value is PM_QOS_DEFAULT_VALUE, pm_qos_update_target specifically uses c->default_value which is set to FREQ_QOS_MIN/MAX_DEFAULT_VALUE when cpufreq_policy_alloc is executed, for this case handling.
Adding check for PM_QOS_DEFAULT_VALUE to let default setting work will fix this problem.
Signed-off-by: Chungkai Yang <Chung-kai.Yang@mediatek.com>
--- V1 -> V2: Check both freq_qos_add/update_request.
Link: https://lore.kernel.org/lkml/20230626035144.19717-1-Chung-kai.Yang@mediatek.com/ --- kernel/power/qos.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/kernel/power/qos.c b/kernel/power/qos.c index af51ed6d45ef..260aca45c681 100644 --- a/kernel/power/qos.c +++ b/kernel/power/qos.c @@ -531,7 +531,7 @@ int freq_qos_add_request(struct freq_constraints *qos, { int ret; - if (IS_ERR_OR_NULL(qos) || !req || value < 0) + if (IS_ERR_OR_NULL(qos) || !req || (value < 0 && value != PM_QOS_DEFAULT_VALUE)) return -EINVAL; if (WARN(freq_qos_request_active(req), @@ -563,7 +563,7 @@ EXPORT_SYMBOL_GPL(freq_qos_add_request); */ int freq_qos_update_request(struct freq_qos_request *req, s32 new_value) { - if (!req || new_value < 0) + if (!req || (new_value < 0 && new_value != PM_QOS_DEFAULT_VALUE)) return -EINVAL; if (WARN(!freq_qos_request_active(req), -- 2.18.0
| |