Messages in this thread | | | From | "Li, Xin3" <> | Subject | RE: [PATCH 2/3] x86/vector: Replace IRQ_MOVE_CLEANUP_VECTOR with a timer callback | Date | Tue, 20 Jun 2023 17:30:41 +0000 |
| |
> > +/* > > + * Called with vector_lock held > > + */ > > Such a comment is patently bad. > > > +static void __vector_cleanup(struct vector_cleanup *cl, bool > > +check_irr) > > { > .... > > lockdep_assert_held(&vector_lock); > > Documents the requirement clearly _and_ catches any caller which does not hold > the lock when lockdep is enabled.
Peter Z gave the same comment, I will address in the next iteration.
Thanks! Xin
| |