Messages in this thread | | | Date | Tue, 20 Jun 2023 11:08:39 +0200 | From | Johan Hovold <> | Subject | Re: [RFC PATCH 2/5] gnss: ubx: use new helper to remove open coded regulator handling |
| |
On Tue, Jun 20, 2023 at 11:04:27AM +0200, Wolfram Sang wrote: > > I'm a bit torn about this one as I'm generally sceptical of devres and > > especially helpers that enable or register resources, which just tends to > > lead to subtle bugs. > > It is good to think twice with devres, but I also really like this > helper. En-/Disabling the regulator matches the life cycle of the device > itself. The boilerplate code it removes tends also to be error prone.
So can the "trival" devres conversions be:
https://lore.kernel.org/lkml/ZJFqCQ8bbBoX3l1g@hovoldconsulting.com
I meant to CC you on my reply there.
Johan [unhandled content-type:application/pgp-signature] | |