Messages in this thread | | | Date | Tue, 20 Jun 2023 11:04:27 +0200 | From | Wolfram Sang <> | Subject | Re: [RFC PATCH 2/5] gnss: ubx: use new helper to remove open coded regulator handling |
| |
> I'm a bit torn about this one as I'm generally sceptical of devres and > especially helpers that enable or register resources, which just tends to > lead to subtle bugs.
It is good to think twice with devres, but I also really like this helper. En-/Disabling the regulator matches the life cycle of the device itself. The boilerplate code it removes tends also to be error prone.
> Care to respin this one after dropping the merge patch?
Sure, I'll respin this series right away
[unhandled content-type:application/pgp-signature]
| |