Messages in this thread | | | Date | Mon, 19 Jun 2023 17:01:47 +0100 | Subject | Re: [PATCH net v6 1/6] net: dsa: mt7530: set all CPU ports in MT7531_CPU_PMAP | From | Florian Fainelli <> |
| |
On 6/17/2023 7:26 AM, arinc9.unal@gmail.com wrote: > From: Arınç ÜNAL <arinc.unal@arinc9.com> > > MT7531_CPU_PMAP represents the destination port mask for trapped-to-CPU > frames (further restricted by PCR_MATRIX). > > Currently the driver sets the first CPU port as the single port in this bit > mask, which works fine regardless of whether the device tree defines port > 5, 6 or 5+6 as CPU ports. This is because the logic coincides with DSA's > logic of picking the first CPU port as the CPU port that all user ports are > affine to, by default. > > An upcoming change would like to influence DSA's selection of the default > CPU port to no longer be the first one, and in that case, this logic needs > adaptation. > > Since there is no observed leakage or duplication of frames if all CPU > ports are defined in this bit mask, simply include them all. > > Suggested-by: Russell King (Oracle) <linux@armlinux.org.uk> > Suggested-by: Vladimir Oltean <olteanv@gmail.com> > Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com> > Reviewed-by: Vladimir Oltean <olteanv@gmail.com> > Reviewed-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com> -- Florian
| |