Messages in this thread | | | Date | Mon, 19 Jun 2023 13:12:30 +0100 | From | "Russell King (Oracle)" <> | Subject | Re: [PATCH net v6 3/6] net: dsa: mt7530: fix handling of BPDUs on MT7530 switch |
| |
On Sat, Jun 17, 2023 at 09:26:46AM +0300, arinc9.unal@gmail.com wrote: > From: Arınç ÜNAL <arinc.unal@arinc9.com> > > BPDUs are link-local frames, therefore they must be trapped to the CPU > port. Currently, the MT7530 switch treats BPDUs as regular multicast > frames, therefore flooding them to user ports. To fix this, set BPDUs to be > trapped to the CPU port. Group this on mt7530_setup() and > mt7531_setup_common() into mt753x_trap_frames() and call that. > > Fixes: b8f126a8d543 ("net-next: dsa: add dsa support for Mediatek MT7530 switch") > Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com>
Reviewed-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Thanks!
> +static void > +mt753x_trap_frames(struct mt7530_priv *priv)
The only niggle is that it's not necessary to split this line, but as other functions do this, it's better to follow the already established convention in the file.
-- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
| |