| Date | Fri, 16 Jun 2023 10:58:27 -0300 | Subject | Re: [PATCH v2 02/11] kbuild: rust_is_available: fix version check when CC has multiple arguments | From | Martin Rodriguez Reboredo <> |
| |
On 6/15/23 21:16, Miguel Ojeda wrote: > From: Russell Currey <ruscur@russell.cc> > > rust_is_available.sh uses cc-version.sh to identify which C compiler is > in use, as scripts/Kconfig.include does. cc-version.sh isn't designed to > be able to handle multiple arguments in one variable, i.e. "ccache clang". > Its invocation in rust_is_available.sh quotes "$CC", which makes > $1 == "ccache clang" instead of the intended $1 == ccache & $2 == clang. > > cc-version.sh could also be changed to handle having "ccache clang" as one > argument, but it only has the one consumer upstream, making it simpler to > fix the caller here. > > Signed-off-by: Russell Currey <ruscur@russell.cc> > Fixes: 78521f3399ab ("scripts: add `rust_is_available.sh`") > Link: https://github.com/Rust-for-Linux/linux/pull/873 > [ Reworded title prefix and reflow line to 75 columns. ] > Signed-off-by: Miguel Ojeda <ojeda@kernel.org> > --- > [...]
Reviewed-by: Martin Rodriguez Reboredo <yakoyoku@gmail.com>
|