Messages in this thread | ![/](/images/icornerl.gif) | | Date | Fri, 16 Jun 2023 12:00:15 -0300 | Subject | Re: [PATCH v2 11/11] kbuild: rust_is_available: add test suite | From | Martin Rodriguez Reboredo <> |
| |
On 6/15/23 21:16, Miguel Ojeda wrote: > The `rust_is_available.sh` script runs for everybody compiling the > kernel, even if not using Rust. Therefore, it is important to ensure > that the script is correct to avoid breaking people's compilation. > > In addition, the script needs to be able to handle a set of subtle > cases, including parsing version strings of different tools. > > Therefore, maintenance of this script can be greatly eased with > a set of tests. > > Thus add a test suite to cover hopefully most of the setups that > the script may encounter in the wild. Extra setups can be easily > added later on if missing. > > The script currently covers all the branches of the shell script, > including several ways in which they may be entered. > > Python is used for this script, since the script under test > does not depend on Rust, thus hopefully making it easier for others > to use if the need arises. > > Signed-off-by: Miguel Ojeda <ojeda@kernel.org> > --- > [...]
Reviewed-by: Martin Rodriguez Reboredo <yakoyoku@gmail.com>
| ![\](/images/icornerr.gif) |