Messages in this thread | | | Date | Mon, 12 Jun 2023 16:32:10 -0600 | Subject | Re: [PATCHv2] selftests: damon: add config file | From | Shuah Khan <> |
| |
On 6/9/23 13:16, SeongJae Park wrote: > On Wed, 12 Apr 2023 16:58:06 +0000 SeongJae Park <sj@kernel.org> wrote: > >> Hi Anders, >> >> On Wed, 12 Apr 2023 11:28:54 +0200 Anders Roxell <anders.roxell@linaro.org> wrote: >> >>> Building and running the subsuite 'damon' of kselftest, shows the >>> following issues: >>> selftests: damon: debugfs_attrs.sh >>> /sys/kernel/debug/damon not found >>> >>> By creating a config file enabling DAMON fragments in the >>> selftests/damon/ directory the tests pass. >>> >>> Fixes: b348eb7abd09 ("mm/damon: add user space selftests") >>> Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org> >> >> checkpatch.pl is warning as below: >> >> WARNING: Reported-by: should be immediately followed by Link: with a URL to the report >> #20: >> Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org> >> Signed-off-by: Anders Roxell <anders.roxell@linaro.org> >> >> The reason for the warning can be found from commit d7f1d71e5ef6 ("checkpatch: >> warn when Reported-by: is not followed by Link:")'s commit message. Do you >> have a link to put here? I guess the report was made inside Linaro, so might >> have no publicly available link. Maybe better to add some notes or some funny >> tag like "Link: N/A # no publicly-available link of the report" for convincing >> the tool, but I don't think this should be a blocker for this patch. >> >>> Signed-off-by: Anders Roxell <anders.roxell@linaro.org> >> >> Reviewed-by: SeongJae Park <sj@kernel.org> > > Shuah, may I ask your opinion on this patch? > > I'm also cc-ing Andrew, as he may also interested in picking this patch. >
If Andrew wants to pick this up:
Acked-by: Shuah Khan <skhan@linuxfoundation.org>
thanks, -- Shuah
| |