lkml.org 
[lkml]   [2023]   [Apr]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCHv2] selftests: damon: add config file
Date
Hi Anders,

On Wed, 12 Apr 2023 11:28:54 +0200 Anders Roxell <anders.roxell@linaro.org> wrote:

> Building and running the subsuite 'damon' of kselftest, shows the
> following issues:
> selftests: damon: debugfs_attrs.sh
> /sys/kernel/debug/damon not found
>
> By creating a config file enabling DAMON fragments in the
> selftests/damon/ directory the tests pass.
>
> Fixes: b348eb7abd09 ("mm/damon: add user space selftests")
> Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org>

checkpatch.pl is warning as below:

WARNING: Reported-by: should be immediately followed by Link: with a URL to the report
#20:
Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org>
Signed-off-by: Anders Roxell <anders.roxell@linaro.org>

The reason for the warning can be found from commit d7f1d71e5ef6 ("checkpatch:
warn when Reported-by: is not followed by Link:")'s commit message. Do you
have a link to put here? I guess the report was made inside Linaro, so might
have no publicly available link. Maybe better to add some notes or some funny
tag like "Link: N/A # no publicly-available link of the report" for convincing
the tool, but I don't think this should be a blocker for this patch.

> Signed-off-by: Anders Roxell <anders.roxell@linaro.org>

Reviewed-by: SeongJae Park <sj@kernel.org>


Thanks,
SJ

> ---
> tools/testing/selftests/damon/config | 7 +++++++
> 1 file changed, 7 insertions(+)
> create mode 100644 tools/testing/selftests/damon/config
>
> diff --git a/tools/testing/selftests/damon/config b/tools/testing/selftests/damon/config
> new file mode 100644
> index 000000000000..0daf38974eb0
> --- /dev/null
> +++ b/tools/testing/selftests/damon/config
> @@ -0,0 +1,7 @@
> +CONFIG_DAMON=y
> +CONFIG_DAMON_SYSFS=y
> +CONFIG_DAMON_DBGFS=y
> +CONFIG_DAMON_PADDR=y
> +CONFIG_DAMON_VADDR=y
> +CONFIG_DAMON_RECLAIM=y
> +CONFIG_DAMON_LRU_SORT=y
> --
> 2.39.2

\
 
 \ /
  Last update: 2023-04-12 18:59    [W:0.070 / U:0.004 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site