Messages in this thread | | | Date | Tue, 9 May 2023 09:04:46 +0200 | Subject | Re: [PATCHv2 6/6] arm64: dts: socfpga: add hwmon properties | From | Krzysztof Kozlowski <> |
| |
On 08/05/2023 23:28, dinh.nguyen@linux.intel.com wrote: > From: Dinh Nguyen <dinh.nguyen@linux.intel.com> > > Add the hardware monitoring properties for Stratix10 and Agilex. > > Signed-off-by: Dinh Nguyen <dinh.nguyen@linux.intel.com> > --- > v2: add platform specific platforms to DTS files > --- > .../boot/dts/altera/socfpga_stratix10.dtsi | 4 ++ > .../dts/altera/socfpga_stratix10_socdk.dts | 31 +++++++++ > arch/arm64/boot/dts/intel/socfpga_agilex.dtsi | 4 ++ > .../boot/dts/intel/socfpga_agilex_n6000.dts | 66 +++++++++++++++++++ > .../boot/dts/intel/socfpga_agilex_socdk.dts | 66 +++++++++++++++++++ > .../dts/intel/socfpga_agilex_socdk_nand.dts | 66 +++++++++++++++++++ > .../boot/dts/intel/socfpga_n5x_socdk.dts | 47 +++++++++++++ > 7 files changed, 284 insertions(+) > > diff --git a/arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi b/arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi > index 41c9eb51d0ee..2526afa687d6 100644 > --- a/arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi > +++ b/arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi > @@ -633,6 +633,10 @@ svc { > fpga_mgr: fpga-mgr { > compatible = "intel,stratix10-soc-fpga-mgr"; > }; > + > + hwmon: temp-volt {
Node names should be generic, so maybe just hwmon. https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
> + compatible = "intel,socfpga-stratix10-hwmon", "intel,socfpga-hwmon";
Test your bindings. Your bindings or this part do not match at all. Driver does not match it either.
Best regards, Krzysztof
| |