Messages in this thread | | | Date | Thu, 25 May 2023 15:47:46 -0500 | Subject | Re: [PATCHv2 3/6] hwmon: (socfpga) Add hardware monitoring support on SoCFPGA platforms | From | Dinh Nguyen <> |
| |
Hi Armin,
On 5/8/2023 7:57 PM, Armin Wolf wrote: > Am 08.05.23 um 23:28 schrieb dinh.nguyen@linux.intel.com: > >> From: Dinh Nguyen <dinh.nguyen@linux.intel.com> >> >> The driver supports 64-bit SoCFPGA platforms for temperature and voltage >> reading using the platform's SDM(Secure Device Manager). The driver >> also uses the Stratix10 Service layer driver. >> >> This driver only supports OF SoCFPGA 64-bit platforms. >> >> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> >> Signed-off-by: Dinh Nguyen <dinh.nguyen@linux.intel.com> >> --- >> v2: clean up race conditions in probe/remove functions >> move changes in service driver to a separate patch >> fix undefined 'ret' value in socfpga_read() >> fix up socfpga_hwmon_err_to_errno() to handle signed integer >> add platform specific dts binding >> --- >> Documentation/hwmon/index.rst | 1 + >> Documentation/hwmon/socfpga-hwmon.rst | 30 ++ >> drivers/hwmon/Kconfig | 11 + >> drivers/hwmon/Makefile | 1 + >> drivers/hwmon/socfpga-hwmon.c | 408 ++++++++++++++++++++++++++ >> 5 files changed, 451 insertions(+) >> create mode 100644 Documentation/hwmon/socfpga-hwmon.rst >> create mode 100644 drivers/hwmon/socfpga-hwmon.c ICENSE("GPL");
Thanks for the review. I've addressed all of your comments in V3.
Dinh
| |