lkml.org 
[lkml]   [2023]   [May]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v5 1/3] dt-bindings: misc: esm: Add ESM support for TI K3 devices
From
Hi Krzysztof

On 04/05/23 12:21, Krzysztof Kozlowski wrote:
> On 03/05/2023 14:32, Neha Malcom Francis wrote:
>> Document the binding for TI K3 ESM (Error Signaling Module) block.
>>
>> Signed-off-by: Neha Malcom Francis <n-francis@ti.com>
>
> ???
>
> You were already asked to keep it and it was in v4, so you had to
> explicitly remove it from your git... It takes me time to figure out
> what is happening here. But ok, if you do not keep my review, comment
> follows.
>
> ...

Really sorry about that, forgot to add it back for v5. Sending next
version soon...

>
>> + ti,esm-pins:
>> + $ref: /schemas/types.yaml#/definitions/uint32-array
>> + description:
>> + integer array of ESM interrupt pins to route to external event pin
>> + which can be used to reset the SoC.
>> + minItems: 1
>> + maxItems: 255
>> +
>> +additionalProperties: false
>
> Put aditionalProperties after required:, just like in example-schema.
>
>> +
>> +required:
>> + - compatible
>> + - reg
>> + - ti,esm-pins
>
>
>
> Best regards,
> Krzysztof
>

--
Thanking You
Neha Malcom Francis

\
 
 \ /
  Last update: 2023-05-04 09:44    [W:0.063 / U:0.716 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site