Messages in this thread Patch in this message | | | Date | Wed, 31 May 2023 12:04:50 -0000 | From | "tip-bot2 for Arnd Bergmann" <> | Subject | [tip: sched/core] sched: Hide unused sched_update_scaling() |
| |
The following commit has been merged into the sched/core branch of tip:
Commit-ID: d55ebae3f3122b07689cc4c34043114e09ce904c Gitweb: https://git.kernel.org/tip/d55ebae3f3122b07689cc4c34043114e09ce904c Author: Arnd Bergmann <arnd@arndb.de> AuthorDate: Mon, 22 May 2023 21:50:17 +02:00 Committer: Peter Zijlstra <peterz@infradead.org> CommitterDate: Tue, 30 May 2023 22:46:24 +02:00
sched: Hide unused sched_update_scaling()
This function is only used when CONFIG_SMP is enabled, without that there is no caller and no prototype:
kernel/sched/fair.c:688:5: error: no previous prototype for 'sched_update_scaling' [-Werror=missing-prototypes
Hide the definition in the same #ifdef check as the declaration.
Fixes: 8a99b6833c88 ("sched: Move SCHED_DEBUG sysctl to debugfs") Signed-off-by: Arnd Bergmann <arnd@arndb.de> Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org> Reviewed-by: Vincent Guittot <vincent.guittot@linaro.org> Link: https://lore.kernel.org/r/20230522195021.3456768-2-arnd@kernel.org --- kernel/sched/fair.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 48b6f0c..2c1b345 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -684,7 +684,7 @@ struct sched_entity *__pick_last_entity(struct cfs_rq *cfs_rq) /************************************************************** * Scheduling class statistics methods: */ - +#ifdef CONFIG_SMP int sched_update_scaling(void) { unsigned int factor = get_update_sysctl_factor(); @@ -702,6 +702,7 @@ int sched_update_scaling(void) return 0; } #endif +#endif /* * delta /= w
| |