lkml.org 
[lkml]   [2023]   [May]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 4/5] sched: make task_vruntime_update() prototype visible
From


On 5/23/2023 1:20 AM, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> Having the prototype next to the caller but not visible to the callee causes
> a W=1 warning:
>
> kernel/sched/fair.c:11985:6: error: no previous prototype for 'task_vruntime_update' [-Werror=missing-prototypes]
>
> Move this to a header, as we do for all other function declarations.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>


LGTM.
Reviewed-by: Mukesh Ojha <quic_mojha@quicinc.com>

-- Mukesh

> ---
> kernel/sched/core.c | 2 --
> kernel/sched/sched.h | 1 +
> 2 files changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/kernel/sched/core.c b/kernel/sched/core.c
> index 044bcdf4181a..aae6ff717c55 100644
> --- a/kernel/sched/core.c
> +++ b/kernel/sched/core.c
> @@ -6030,8 +6030,6 @@ static inline struct task_struct *pick_task(struct rq *rq)
> BUG(); /* The idle class should always have a runnable task. */
> }
>
> -extern void task_vruntime_update(struct rq *rq, struct task_struct *p, bool in_fi);
> -
> static void queue_core_balance(struct rq *rq);
>
> static struct task_struct *
> diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h
> index 44b34836bb60..d5ac0af1eede 100644
> --- a/kernel/sched/sched.h
> +++ b/kernel/sched/sched.h
> @@ -1245,6 +1245,7 @@ static inline raw_spinlock_t *__rq_lockp(struct rq *rq)
>
> bool cfs_prio_less(const struct task_struct *a, const struct task_struct *b,
> bool fi);
> +void task_vruntime_update(struct rq *rq, struct task_struct *p, bool in_fi);
>
> /*
> * Helpers to check if the CPU's core cookie matches with the task's cookie

\
 
 \ /
  Last update: 2023-05-23 09:03    [W:0.301 / U:2.432 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site