lkml.org 
[lkml]   [2023]   [May]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 1/2] x86/PCI: Fix a sanity check in pirq_convert_irt_table()
From
Le 19/05/2023 à 13:21, Maciej W. Rozycki a écrit :
> On Sat, 6 May 2023, Christophe JAILLET wrote:
>
>> We compare the size in bytes of a struct (and its ending flexible array)
>> with the number of elements in a flexible array.
>
> Incorrect, see the inline documentation for the struct.

Ouch.

As you explained in your reply for the 2nd patch:
irT_routing_table != irQ_routing_table

Sorry for the noise.

CJ

>
>> This is wrong and "ir->size < ir->used" is likely to be always false.
>
> Hopefully, but we've seen all kinds of rubbish in PC BIOS data, and this
> data structure seems available for OEMs to program with a tool called BCP.
> Better safe than sorry. Therefore, NAK.
>
> Maciej
>

\
 
 \ /
  Last update: 2023-05-19 19:34    [W:0.097 / U:0.052 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site