Messages in this thread | | | Date | Fri, 19 May 2023 12:21:50 +0100 (BST) | From | "Maciej W. Rozycki" <> | Subject | Re: [PATCH 1/2] x86/PCI: Fix a sanity check in pirq_convert_irt_table() |
| |
On Sat, 6 May 2023, Christophe JAILLET wrote:
> We compare the size in bytes of a struct (and its ending flexible array) > with the number of elements in a flexible array.
Incorrect, see the inline documentation for the struct.
> This is wrong and "ir->size < ir->used" is likely to be always false.
Hopefully, but we've seen all kinds of rubbish in PC BIOS data, and this data structure seems available for OEMs to program with a tool called BCP. Better safe than sorry. Therefore, NAK.
Maciej
| |