Messages in this thread | | | From | Zi Yan <> | Subject | Re: [RESEND PATCH v1 1/5] mm: vmalloc must set pte via arch code | Date | Thu, 11 May 2023 11:00:37 -0400 |
| |
On 11 May 2023, at 9:21, Ryan Roberts wrote:
> It is bad practice to directly set pte entries within a pte table. > Instead all modifications must go through arch-provided helpers such as > set_pte_at() to give the arch code visibility and allow it to validate > (and potentially modify) the operation. > > Fixes: 3e9a9e256b1e ("mm: add a vmap_pfn function") > Signed-off-by: Ryan Roberts <ryan.roberts@arm.com> > --- > mm/vmalloc.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > LGTM. Reviewed-by: Zi Yan <ziy@nvidia.com>
-- Best Regards, Yan, Zi [unhandled content-type:application/pgp-signature] | |