Messages in this thread | | | From | Zi Yan <> | Subject | Re: [RESEND PATCH v1 2/5] mm: damon must atomically clear young on ptes and pmds | Date | Thu, 11 May 2023 11:01:12 -0400 |
| |
On 11 May 2023, at 9:21, Ryan Roberts wrote:
> It is racy to non-atomically read a pte, then clear the young bit, then > write it back as this could discard dirty information. Further, it is > bad practice to directly set a pte entry within a table. Instead > clearing young must go through the arch-provided helper, > ptep_test_and_clear_young() to ensure it is modified atomically and to > give the arch code visibility and allow it to validate (and potentially > modify) the operation. > > Fixes: 46c3a0accdc4 ("mm/damon/vaddr: separate commonly usable functions") > Signed-off-by: Ryan Roberts <ryan.roberts@arm.com> > --- > mm/damon/ops-common.c | 16 ++++++---------- > mm/damon/ops-common.h | 4 ++-- > mm/damon/paddr.c | 4 ++-- > mm/damon/vaddr.c | 4 ++-- > 4 files changed, 12 insertions(+), 16 deletions(-) > LGTM. Reviewed-by: Zi Yan <ziy@nvidia.com>
-- Best Regards, Yan, Zi [unhandled content-type:application/pgp-signature] | |