Messages in this thread | | | Date | Thu, 11 May 2023 16:44:16 +0300 | From | Dmitry Rokosov <> | Subject | Re: [PATCH v14 5/6] dt-bindings: clock: meson: add A1 Peripherals clock controller bindings |
| |
Hello Martin,
Sorry for the delayed response as I was on vacation without laptop.
On Mon, May 01, 2023 at 08:51:30PM +0200, Martin Blumenstingl wrote: > Hi Dmitry, > > On Wed, Apr 26, 2023 at 11:58 AM Dmitry Rokosov > <ddrokosov@sberdevices.ru> wrote: > > > > Add the documentation for Amlogic A1 Peripherals clock driver, > > and A1 Peripherals clock controller bindings. > Maybe a native English speaker can comment on whether it's > "peripheral" or "peripherals". >
Ok
> [...] > > Signed-off-by: Jian Hu <jian.hu@amlogic.com> > > Signed-off-by: Dmitry Rokosov <ddrokosov@sberdevices.ru> > > Reviewed-by: Rob Herring <robh@kernel.org> > > --- > > .../bindings/clock/amlogic,a1-clkc.yaml | 73 +++++++++++ > > .../bindings/clock/amlogic,a1-pll-clkc.yaml | 5 +- > > include/dt-bindings/clock/amlogic,a1-clkc.h | 114 ++++++++++++++++++ > I have seen that Yu Tu named the S4 peripheral clock controller > binding and driver "s4-peripherals-clkc" [0]. > Does it make sense to apply the same naming here as well?
Yes, it makes sense. I will prepare a new version with the necessary renaming.
> > > Best regards, > Martin > > > [0] https://lore.kernel.org/linux-amlogic/20230417065005.24967-3-yu.tu@amlogic.com/
-- Thank you, Dmitry
| |