Messages in this thread | | | Date | Tue, 2 May 2023 09:39:12 +0200 | Subject | Re: [PATCH v14 5/6] dt-bindings: clock: meson: add A1 Peripherals clock controller bindings | From | Krzysztof Kozlowski <> |
| |
On 02/05/2023 03:38, Christian Hewitt wrote: >> On 1 May 2023, at 7:51 pm, Martin Blumenstingl <martin.blumenstingl@googlemail.com> wrote: >> >> Hi Dmitry, >> >> On Wed, Apr 26, 2023 at 11:58 AM Dmitry Rokosov >> <ddrokosov@sberdevices.ru> wrote: >>> >>> Add the documentation for Amlogic A1 Peripherals clock driver, >>> and A1 Peripherals clock controller bindings. >> Maybe a native English speaker can comment on whether it's >> "peripheral" or "peripherals". > > I’m not a grammar specialist, but I would write: > > “Add documentation and bindings for the Amlogic A1 SoC peripherals > clock driver” > > Peripherals is the correct plural but reads better when you add > context on the type of peripherals.
Drop the "driver" references - from the binding itself and from commit msg. The bindings are for hardware, not for the driver, so: "for the Amlogic A1 SoC peripherals clock controller.".
Best regards, Krzysztof
| |