Messages in this thread | | | Subject | Re: [PATCH] accel/qaic: silence some uninitialized variable warnings | From | Pranjal Ramajor Asha Kanojiya <> | Date | Fri, 12 May 2023 01:16:59 +0530 |
| |
On 5/3/2023 4:11 PM, Dan Carpenter wrote: > Smatch complains that these are not initialized if get_cntl_version() > fails but we still print them in the debug message. Not the end of > the world, but true enough. Let's just initialize them to a dummy value > to make the checker happy. > > Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> > --- > drivers/accel/qaic/qaic_drv.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/accel/qaic/qaic_drv.c b/drivers/accel/qaic/qaic_drv.c > index ff80eb571729..e10e8b603e37 100644 > --- a/drivers/accel/qaic/qaic_drv.c > +++ b/drivers/accel/qaic/qaic_drv.c > @@ -263,7 +263,7 @@ static void qaic_destroy_drm_device(struct qaic_device *qdev, s32 partition_id) > static int qaic_mhi_probe(struct mhi_device *mhi_dev, const struct mhi_device_id *id) > { > struct qaic_device *qdev; > - u16 major, minor; > + u16 major = -1, minor = -1; > int ret; > > /* >
Thank you Dan for the patch.
Reviewed-by: Pranjal Ramajor Asha Kanojiya <quic_pkanojiy@quicinc.com>
I agree with Jeff's comment to sort the variable declaration length wise.
| |