lkml.org 
[lkml]   [2023]   [May]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] accel/qaic: silence some uninitialized variable warnings
From
On 5/10/2023 10:48 AM, Dan Carpenter wrote:
> On Wed, May 10, 2023 at 08:57:03AM -0600, Jeffrey Hugo wrote:
>> On 5/3/2023 4:41 AM, Dan Carpenter wrote:
>>> Smatch complains that these are not initialized if get_cntl_version()
>>> fails but we still print them in the debug message. Not the end of
>>> the world, but true enough. Let's just initialize them to a dummy value
>>> to make the checker happy.
>>>
>>> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
>>
>> Thanks for the cleanup.
>>
>> Reviewed-by: Jeffrey Hugo <quic_jhugo@quicinc.com>
>>
>> Could use a fixes tag
>
> The fixes tag thing could have gone either way. It's really minor.
>
>> and also I'd prefer to maintain the style of sorting
>> the variable declaration lines by line length. Given the minor nature of
>> these nits, I plan to address them.
>
> Thanks!

Pushed to drm-misc-fixes

-Jeff

\
 
 \ /
  Last update: 2023-05-16 21:25    [W:0.220 / U:0.084 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site