lkml.org 
[lkml]   [2023]   [Apr]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v2 2/7] dt-bindings: soundwire: qcom: add 16-bit sample interval
From
On 04/04/2023 16:21, Rob Herring wrote:
>> diff --git a/Documentation/devicetree/bindings/soundwire/qcom,soundwire.yaml b/Documentation/devicetree/bindings/soundwire/qcom,soundwire.yaml
>> index c283c594fb5c..883b8be9be1b 100644
>> --- a/Documentation/devicetree/bindings/soundwire/qcom,soundwire.yaml
>> +++ b/Documentation/devicetree/bindings/soundwire/qcom,soundwire.yaml
>> @@ -86,7 +86,7 @@ properties:
>> qcom,ports-sinterval-low:
>> $ref: /schemas/types.yaml#/definitions/uint8-array
>> description:
>> - Sample interval low of each data port.
>> + Sample interval (only lowest byte) of each data port.
>> Out ports followed by In ports. Used for Sample Interval calculation.
>> Value of 0xff indicates that this option is not implemented
>> or applicable for the respective data port.
>> @@ -94,6 +94,19 @@ properties:
>> minItems: 3
>> maxItems: 16
>>
>> + qcom,ports-sinterval:
>> + $ref: /schemas/types.yaml#/definitions/uint32-array
>> + description:
>> + Sample interval of each data port.
>> + Out ports followed by In ports. Used for Sample Interval calculation.
>> + Value of 0xffff indicates that this option is not implemented
>> + or applicable for the respective data port.
>> + More info in MIPI Alliance SoundWire 1.0 Specifications.
>> + minItems: 3
>> + maxItems: 16
>> + items:
>> + maximum: 0xffff
>
> Why not use uint16-array?

Because I am afraid it will grow in next version to 24 or 32 bits. I can
change easily maximum, but if I put here uint16-array, all DTS will have
/bytes 16/ annotation.


Best regards,
Krzysztof

\
 
 \ /
  Last update: 2023-04-04 20:18    [W:0.921 / U:0.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site