lkml.org 
[lkml]   [2023]   [Apr]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v2 2/7] dt-bindings: soundwire: qcom: add 16-bit sample interval
From


On 03/04/2023 14:24, Krzysztof Kozlowski wrote:
> The port sample interval was always 16-bit, split into low and high
> bytes. This split was unnecessary, although harmless for older devices
> because all of them used only lower byte (so values < 0xff). With
> support for Soundwire controller on Qualcomm SM8550 and its devices,
> both bytes will be used, thus add a new 'qcom,ports-sinterval' property
> to allow 16-bit sample intervals.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> .../bindings/soundwire/qcom,soundwire.yaml | 22 +++++++++++++++++--
> 1 file changed, 20 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/soundwire/qcom,soundwire.yaml b/Documentation/devicetree/bindings/soundwire/qcom,soundwire.yaml
> index c283c594fb5c..883b8be9be1b 100644
> --- a/Documentation/devicetree/bindings/soundwire/qcom,soundwire.yaml
> +++ b/Documentation/devicetree/bindings/soundwire/qcom,soundwire.yaml
> @@ -86,7 +86,7 @@ properties:
> qcom,ports-sinterval-low:
> $ref: /schemas/types.yaml#/definitions/uint8-array
> description:
> - Sample interval low of each data port.
> + Sample interval (only lowest byte) of each data port.
> Out ports followed by In ports. Used for Sample Interval calculation.
> Value of 0xff indicates that this option is not implemented
> or applicable for the respective data port.
> @@ -94,6 +94,19 @@ properties:
> minItems: 3
> maxItems: 16
>
> + qcom,ports-sinterval:
> + $ref: /schemas/types.yaml#/definitions/uint32-array

Should this not be ref: /schemas/types.yaml#/definitions/uint16-array ?


--srini
> + description:
> + Sample interval of each data port.
> + Out ports followed by In ports. Used for Sample Interval calculation.
> + Value of 0xffff indicates that this option is not implemented
> + or applicable for the respective data port.
> + More info in MIPI Alliance SoundWire 1.0 Specifications.
> + minItems: 3
> + maxItems: 16
> + items:
> + maximum: 0xffff
> +
> qcom,ports-offset1:
> $ref: /schemas/types.yaml#/definitions/uint8-array
> description:
> @@ -219,10 +232,15 @@ required:
> - '#size-cells'
> - qcom,dout-ports
> - qcom,din-ports
> - - qcom,ports-sinterval-low
> - qcom,ports-offset1
> - qcom,ports-offset2
>
> +oneOf:
> + - required:
> + - qcom,ports-sinterval-low
> + - required:
> + - qcom,ports-sinterval
> +
> additionalProperties: false
>
> examples:

\
 
 \ /
  Last update: 2023-04-12 17:29    [W:0.218 / U:0.292 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site