Messages in this thread | | | Date | Mon, 3 Apr 2023 22:07:59 +0100 | From | Mark Brown <> | Subject | Re: [PATCH v5 1/3] regmap: Pass irq_drv_data as a parameter for set_type_config() |
| |
On Sun, Mar 26, 2023 at 12:25:57PM -0400, William Breathitt Gray wrote:
> Changes in v5: > - Wrap lines to 100 characters rather than 80
It's good to keep things under 80 where we can.
> int (*set_type_config)(unsigned int **buf, unsigned int type, > - const struct regmap_irq *irq_data, int idx); > + const struct regmap_irq *irq_data, int idx, void *irq_drv_data); > unsigned int (*get_irq_reg)(struct regmap_irq_chip_data *data, > unsigned int base, int index); > void *irq_drv_data;
There's no benefit from overflowing here and...
> @@ -1660,7 +1660,8 @@ struct regmap_irq_chip { > unsigned int regmap_irq_get_irq_reg_linear(struct regmap_irq_chip_data *data, > unsigned int base, int index); > int regmap_irq_set_type_config_simple(unsigned int **buf, unsigned int type, > - const struct regmap_irq *irq_data, int idx); > + const struct regmap_irq *irq_data, int idx, > + void *irq_drv_data);
...it's not even consistent. [unhandled content-type:application/pgp-signature] | |