Messages in this thread | | | From | Rob Herring <> | Date | Thu, 27 Apr 2023 09:18:14 -0500 | Subject | Re: [PATCH] dt-bindings: usb: dwc3: xilinx: Add interrupt-names to include hibernation interrupt |
| |
On Fri, Apr 21, 2023 at 8:28 AM Mehta, Piyush <piyush.mehta@amd.com> wrote: > > Hi > > > -----Original Message----- > > From: Rob Herring <robh@kernel.org> > > Sent: Wednesday, April 19, 2023 12:10 AM > > To: Mehta, Piyush <piyush.mehta@amd.com> > > Cc: gregkh@linuxfoundation.org; krzysztof.kozlowski+dt@linaro.org; > > michal.simek@xilinx.com; linux-usb@vger.kernel.org; > > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; Simek, Michal > > <michal.simek@amd.com>; Paladugu, Siva Durga Prasad > > <siva.durga.prasad.paladugu@amd.com>; linux-arm- > > kernel@lists.infradead.org; git (AMD-Xilinx) <git@amd.com> > > Subject: Re: [PATCH] dt-bindings: usb: dwc3: xilinx: Add interrupt-names to > > include hibernation interrupt > > > > On Wed, Apr 12, 2023 at 11:38:43AM +0530, Piyush Mehta wrote: > > > The hibernation feature enabled for Xilinx Versal NET SoC in DWC3 IP. > > > Added host mode interrupts and "usb-wakeup" interrupt-names optional > > > property in the binding schema to capture remote-wakeup and connect/ > > > disconnect event in the hibernation state. > > > > > > Xilinx dwc3-core uses "host" and "otg" interrupts interrupt-names DT > > > properties from dwc3-core. > > > > Is wakeup really not implemented in the DWC3 core, but outside it? > > Wakeup is implemented inside the dwc3-core.
Then it goes in the dwc3 node.
> Initially we planned to implement wakeup interrupt name/interrupt optional property in the dwc3-core. > However, looking at other vendor wakeup interrupt implementation (Commit: dd566faebe9f dt-bindings: usb: qcom,dwc3: refine interrupt requirements) > we moved wakeup property to xilinx USB binding.
That one looks like the phy implements wake-up? I don't know really, but doesn't seem like one to copy.
Rob
| |