Messages in this thread | | | Date | Tue, 18 Apr 2023 13:40:26 -0500 | From | Rob Herring <> | Subject | Re: [PATCH] dt-bindings: usb: dwc3: xilinx: Add interrupt-names to include hibernation interrupt |
| |
On Wed, Apr 12, 2023 at 11:38:43AM +0530, Piyush Mehta wrote: > The hibernation feature enabled for Xilinx Versal NET SoC in DWC3 IP. > Added host mode interrupts and "usb-wakeup" interrupt-names optional > property in the binding schema to capture remote-wakeup and connect/ > disconnect event in the hibernation state. > > Xilinx dwc3-core uses "host" and "otg" interrupts interrupt-names DT > properties from dwc3-core.
Is wakeup really not implemented in the DWC3 core, but outside it?
> > Signed-off-by: Piyush Mehta <piyush.mehta@amd.com> > --- > Note: > - Xilinx uses dwc3-cores interrupt-names DT property. > Link: > Xilinx-dwc3 core: https://github.com/torvalds/linux/blob/master/Documentation/devicetree/bindings/usb/dwc3-xilinx.yaml#L129 > dwc3-core: https://github.com/torvalds/linux/blob/master/Documentation/devicetree/bindings/usb/snps%2Cdwc3.yaml#L42 > --- > Documentation/devicetree/bindings/usb/dwc3-xilinx.yaml | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/Documentation/devicetree/bindings/usb/dwc3-xilinx.yaml b/Documentation/devicetree/bindings/usb/dwc3-xilinx.yaml > index 098b73134a1b..abc32db2448a 100644 > --- a/Documentation/devicetree/bindings/usb/dwc3-xilinx.yaml > +++ b/Documentation/devicetree/bindings/usb/dwc3-xilinx.yaml > @@ -44,6 +44,15 @@ properties: > - const: bus_clk > - const: ref_clk > > + interrupts: > + items: > + - description: Handle to the line usb-wakeup used to wake > + up the host processor. > + > + interrupt-names: > + items: > + - const: usb-wakeup
'wakeup' is the standard name. And you also need 'wakeup-source' property.
> + > resets: > description: > A list of phandles for resets listed in reset-names. > -- > 2.25.1 >
| |