lkml.org 
[lkml]   [2023]   [Apr]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: Rename restrictedmem => guardedmem? (was: Re: [PATCH v10 0/9] KVM: mm: fd-based approach for supporting KVM)
On 17.04.23 18:40, Sean Christopherson wrote:
> On Mon, Apr 17, 2023, David Hildenbrand wrote:
>> On 17.04.23 17:40, Sean Christopherson wrote:
>>> I want to start referring to the code/patches by its syscall/implementation name
>>> instead of "UPM", as "UPM" is (a) very KVM centric, (b) refers to the broader effort
>>> and not just the non-KVM code, and (c) will likely be confusing for future reviewers
>>> since there's nothing in the code that mentions "UPM" in any way.
>>>
>>> But typing out restrictedmem is quite tedious, and git grep shows that "rmem" is
>>> already used to refer to "reserved memory".
>>>
>>> Renaming the syscall to "guardedmem"...
>>
>> restrictedmem, guardedmem, ... all fairly "suboptimal" if you'd ask me ...
>
> I'm definitely open to other suggestions, but I suspect it's going to be difficult
> to be more precise than something like "guarded".

Guardedmem is just as bad as restrictedmem IMHO, sorry.


Restricted: what's restricted? how does the restriction manifest?
secretmem also has it's restrictions/limitations (pinning), why does
that one not fall under the same category?

Make a stranger guess what "restrictedmem" is and I can guarantee that
it has nothing to do with the concept we're introducing here.


Guarded: what's guarded? From whom? For which purpose? How does the
"guarding" manifest?

Again, make a stranger guess what "guardedmem" is and I can guarantee
that it has nothing to do with the concept we're introducing here.

If, at all, the guess might be "guarded storage" [1] on s390x, which, of
course, has nothing to do with the concept here. (storage on s390x is
just the dinosaur slang for memory)


Often, if we fail to find a good name, the concept is either unclear or
not well defined.

So what are the characteristics we want to generalize under that new
name? We want to have an fd, that

(a) cannot be mapped into user space (mmap)
(b) cannot be accessed using ordinary system calls (read/write)
(c) can still be managed like other fds (fallocate, future NUMA
policies?)
(d) can be consumed by some special entities that are allowed to
read/write/map.

So the fd content is inaccessible using the ordinary POSIX syscalls.
It's only accessible by special entities (e.g., KVM).

Most probably I am forgetting something. But maybe that will help to
find a more expressive name. Maybe :)

>
> E.g. we discussed "unmappable" at one point, but the memory can still be mapped,
> just not via mmap(). And it's not just about mappings, e.g. read() and its many
> variants are all disallowed too, despite the kernel direct map still being live
> (modulo SNP requirements).
>

[1] https://man.archlinux.org/man/s390_guarded_storage.2.en

--
Thanks,

David / dhildenb

\
 
 \ /
  Last update: 2023-04-17 19:11    [W:0.226 / U:0.044 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site