Messages in this thread | | | Date | Thu, 13 Apr 2023 18:33:39 +0200 | From | Wolfram Sang <> | Subject | Re: [PATCH v2] i2c: ocores: generate stop condition after timeout in polling mode |
| |
On Thu, Apr 13, 2023 at 11:37:37AM +0200, Matthias Schiffer wrote: > From: Gregor Herburger <gregor.herburger@tq-group.com> > > In polling mode, no stop condition is generated after a timeout. This > causes SCL to remain low and thereby block the bus. If this happens > during a transfer it can cause slaves to misinterpret the subsequent > transfer and return wrong values. > > To solve this, pass the ETIMEDOUT error up from ocores_process_polling() > instead of setting STATE_ERROR directly. The caller is adjusted to call > ocores_process_timeout() on error both in polling and in IRQ mode, which > will set STATE_ERROR and generate a stop condition. > > Fixes: 69c8c0c0efa8 ("i2c: ocores: add polling interface") > Signed-off-by: Gregor Herburger <gregor.herburger@tq-group.com> > Signed-off-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
Applied to for-current, thanks everyone!
[unhandled content-type:application/pgp-signature] | |