Messages in this thread | | | From | Peter Korsgaard <> | Subject | Re: [PATCH v2] i2c: ocores: generate stop condition after timeout in polling mode | Date | Thu, 13 Apr 2023 11:58:26 +0200 |
| |
>>>>> "Matthias" == Matthias Schiffer <matthias.schiffer@ew.tq-group.com> writes:
> From: Gregor Herburger <gregor.herburger@tq-group.com> > In polling mode, no stop condition is generated after a timeout. This > causes SCL to remain low and thereby block the bus. If this happens > during a transfer it can cause slaves to misinterpret the subsequent > transfer and return wrong values.
> To solve this, pass the ETIMEDOUT error up from ocores_process_polling() > instead of setting STATE_ERROR directly. The caller is adjusted to call > ocores_process_timeout() on error both in polling and in IRQ mode, which > will set STATE_ERROR and generate a stop condition.
> Fixes: 69c8c0c0efa8 ("i2c: ocores: add polling interface") > Signed-off-by: Gregor Herburger <gregor.herburger@tq-group.com> > Signed-off-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com> > ---
> v2: style improvements based on feedback from Federico and Andrew. I went > with a slightly different solution than Andrew suggested to avoid using > the ret variable for two different kinds of returns.
Acked-by: Peter Korsgaard <peter@korsgaard.com>
-- Bye, Peter Korsgaard
| |