Messages in this thread | | | Date | Thu, 13 Apr 2023 10:41:23 +0200 | Subject | Re: [PATCH v4 1/3] dt-bindings: phy: Add starfive,jh7110-dphy-rx | From | Krzysztof Kozlowski <> |
| |
On 13/04/2023 04:34, Changhuang Liang wrote: >>>>> + lane_maps: >>>> >>>> Why did this appear? Underscores are not allowed. It looks like you >>>> re-implement some standard property. >>>> >>> >>> Will change to lane-maps. >>> Yes, according to Vinod advice, lane mapping table use device tree >>> to parse makes sense. >> >> Hm, I have a feeling that I saw such property, so you should dig into >> existing and in-flight bindings. >> >> Best regards, >> Krzysztof >> > > A standard property? Like "clocks" or "resets"?
Like lane-polarities now submitted to one MIPI.
Anyway it does not look like a property of a board. You said it is fixed per SoC, so it should be implied from the compatible. Otherwise please explain in description and provide some rationale.
Best regards, Krzysztof
| |