Messages in this thread | | | Date | Thu, 13 Apr 2023 10:34:32 +0800 | Subject | Re: [PATCH v4 1/3] dt-bindings: phy: Add starfive,jh7110-dphy-rx | From | Changhuang Liang <> |
| |
On 2023/4/13 0:55, Krzysztof Kozlowski wrote: > On 12/04/2023 14:42, Changhuang Liang wrote: [...] >>>> >>>> Signed-off-by: Changhuang Liang <changhuang.liang@starfivetech.com> >>>> --- >>>> .../bindings/phy/starfive,jh7110-dphy-rx.yaml | 85 +++++++++++++++++++ >>>> 1 file changed, 85 insertions(+) >>>> create mode 100644 Documentation/devicetree/bindings/phy/starfive,jh7110-dphy-rx.yaml >>>> >> [...] >>>> + >>>> + power-domains: >>>> + maxItems: 1 >>>> + >>>> + lane_maps: >>> >>> Why did this appear? Underscores are not allowed. It looks like you >>> re-implement some standard property. >>> >> >> Will change to lane-maps. >> Yes, according to Vinod advice, lane mapping table use device tree >> to parse makes sense. > > Hm, I have a feeling that I saw such property, so you should dig into > existing and in-flight bindings. > > Best regards, > Krzysztof >
A standard property? Like "clocks" or "resets"?
| |