lkml.org 
[lkml]   [2023]   [Apr]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v11 13/26] gunyah: vm_mgr: Add ioctls to support basic non-proxy VM boot
From
On 4/11/23 4:07 PM, Elliot Berman wrote:
>
>
> On 3/21/2023 7:24 AM, Srinivas Kandagatla wrote:
>
>> On 04/03/2023 01:06, Elliot Berman wrote:
>>> +
>>> +#define GH_VM_START        _IO(GH_IOCTL_TYPE, 0x3)
>> A comment here that this is going to *ONLY* start an un-authenticated
>> VM would be useful to the users.
>>
>
> There is only support for unauthenticated VM in the UAPI being proposed
> and I'd like to re-use GH_VM_START ioctl for other VM types as well. Is
> the comment really useful? I can easily see forgetting to remove the
> comment and then being more confusing once the other VM types get added.

It's up to you. And in general, I think your responses to my
comments have been fine--even when you just explain why you
don't plan to implement my suggestion. Thank you.

-Alex

>
> Thanks,
> Elliot

\
 
 \ /
  Last update: 2023-04-11 23:10    [W:0.627 / U:0.000 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site