Messages in this thread | | | Date | Tue, 11 Apr 2023 14:07:46 -0700 | Subject | Re: [PATCH v11 13/26] gunyah: vm_mgr: Add ioctls to support basic non-proxy VM boot | From | Elliot Berman <> |
| |
On 3/21/2023 7:24 AM, Srinivas Kandagatla wrote:
> On 04/03/2023 01:06, Elliot Berman wrote: >> + >> +#define GH_VM_START _IO(GH_IOCTL_TYPE, 0x3) > A comment here that this is going to *ONLY* start an un-authenticated VM > would be useful to the users. >
There is only support for unauthenticated VM in the UAPI being proposed and I'd like to re-use GH_VM_START ioctl for other VM types as well. Is the comment really useful? I can easily see forgetting to remove the comment and then being more confusing once the other VM types get added.
Thanks, Elliot
| |