lkml.org 
[lkml]   [2023]   [Apr]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4] crypto: hisilicon/trng - add support for HiSTB TRNG
On Fri, Mar 31, 2023 at 06:19:34PM +0800, David Yang wrote:
>
> + struct histb_trng_priv *priv = (struct histb_trng_priv *) rng->priv;

Plesae don't use rng->priv at all. We're trying to phase it
out because it encourages horrible casting like this.

Please follow the model used in the meson driver.

Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

\
 
 \ /
  Last update: 2023-04-01 10:07    [W:0.033 / U:0.392 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site