lkml.org 
[lkml]   [2023]   [Apr]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v4] crypto: hisilicon/trng - add support for HiSTB TRNG
Herbert Xu <herbert@gondor.apana.org.au> 于2023年4月1日周六 16:07写道:
>
> On Fri, Mar 31, 2023 at 06:19:34PM +0800, David Yang wrote:
> >
> > + struct histb_trng_priv *priv = (struct histb_trng_priv *) rng->priv;
>
> Plesae don't use rng->priv at all. We're trying to phase it
> out because it encourages horrible casting like this.
>
> Please follow the model used in the meson driver.
>
> Thanks,
> --
> Email: Herbert Xu <herbert@gondor.apana.org.au>
> Home Page: http://gondor.apana.org.au/~herbert/
> PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Which meson driver? I didn't find any rng module under amlogic/ dir.

\
 
 \ /
  Last update: 2023-04-01 16:06    [W:0.053 / U:0.088 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site