Messages in this thread | | | Date | Fri, 31 Mar 2023 11:49:38 +0300 | From | Sakari Ailus <> | Subject | Re: [PATCH] media: ov8856: Do not check for for module version |
| |
Hi Ricardo,
On Thu, Mar 23, 2023 at 11:44:20PM +0100, Ricardo Ribalda wrote: > It the device is probed in non-zero ACPI D state, the module > identification is delayed until the first streamon. > > The module identification has two parts: deviceID and version. To rea > the version we have to enable OTP read. This cannot be done during > streamon, becase it modifies REG_MODE_SELECT. > > Since the driver has the same behaviour for all the module versions, do > not read the module version from the sensor's OTP. > > Cc: stable@vger.kernel.org > Fixes: 0e014f1a8d54 ("media: ov8856: support device probe in non-zero ACPI D state") > Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
I guess the identification could be done from pre_streamon() callback instead, but the driver doesn't implement it. But the information isn't used for anything indeed so I'll just take this.
Thanks.
-- Kind regards,
Sakari Ailus
| |