Messages in this thread | | | From | Yangtao Li <> | Subject | Re: [PATCH] quota: check for register_sysctl() failure | Date | Mon, 20 Mar 2023 19:40:28 +0800 |
| |
> Well, but this is going to make system unbootable with > CONFIG_QUOTA && !CONFIG_SYSCTL. > Quota functionality actually does not depend on sysctl being > available so just continuing without sysctl is perfectly fine.
To be honest, I'm a little confused. Should we panic if quota registration fails, or should it depend on the user's cmdline parameters? Just like in the filesystem where we can choose whether to panic in case of exceptions.
Or, should we panic if registration fails when CONFIG_QUOTA && CONFIG_SYSCTL are enabled?
BTW, kindly ping for: https://lore.kernel.org/lkml/20230228103515.sb6qpvnmbvenvq73@quack3/
Not sure if you have forgotten to pick these two commits.
Thx, Yangtao
| |