Messages in this thread | | | Date | Mon, 20 Mar 2023 18:11:46 +0100 | From | Jan Kara <> | Subject | Re: [PATCH] quota: check for register_sysctl() failure |
| |
On Mon 20-03-23 19:40:28, Yangtao Li wrote: > > Well, but this is going to make system unbootable with > > CONFIG_QUOTA && !CONFIG_SYSCTL. > > Quota functionality actually does not depend on sysctl being > > available so just continuing without sysctl is perfectly fine. > > To be honest, I'm a little confused. Should we panic if quota > registration fails, or should it depend on the user's cmdline > parameters? Just like in the filesystem where we can choose > whether to panic in case of exceptions. > > Or, should we panic if registration fails when > CONFIG_QUOTA && CONFIG_SYSCTL are enabled?
So I think that just ignoring the failure to register sysctl (as is currently happening) is fine. Honestly, in practice this is not a likely scenario so I don't think it matters much but if we wanted, we could print a message that sysctl registration failed if CONFIG_SYSCTL is enabled.
> BTW, kindly ping for: > https://lore.kernel.org/lkml/20230228103515.sb6qpvnmbvenvq73@quack3/ > > Not sure if you have forgotten to pick these two commits.
Yeah, sorry. Now picked up and pushed.
Honza -- Jan Kara <jack@suse.com> SUSE Labs, CR
| |