Messages in this thread | | | Date | Sun, 19 Mar 2023 21:21:16 -0700 | From | Dmitry Torokhov <> | Subject | Re: [PATCH] Input: iforce - Fix exception handling in iforce_usb_probe() |
| |
On Sun, Mar 19, 2023 at 07:03:00PM +0100, Markus Elfring wrote: > Date: Sun, 19 Mar 2023 18:50:51 +0100 > > The label “fail” was used to jump to another pointer check despite of > the detail in the implementation of the function “iforce_usb_probe” > that it was determined already that a corresponding variable contained > still a null pointer. > > 1. Use more appropriate labels instead. > > 2. Reorder jump targets at the end. > > 3. Delete a redundant check. > > > This issue was detected by using the Coccinelle software.
I am sorry, but I do not understand what the actual issue is. The fact that come Coccinelle script complains is not enough to change the code.
Thanks.
-- Dmitry
| |