Messages in this thread | | | From | Chester Lin <> | Subject | [PATCH v2 0/4] pinctrl: s32: driver improvements and generic struct use | Date | Tue, 21 Mar 2023 00:38:19 +0800 |
| |
Hello,
This patch series contains some improvements for s32 pinctrl drivers suggested by upstream[1], such as - Fix error shadowings and improve return value handlings. - Fix print format. - Remove unnecessary blanks. - Use proper macros and helpers to simplify codes. - Refactor config param parsing and remove config arguments that are never used. - Use generic struct pingroup and struct pinfunction to describe pin data.
Regards, Chester
[1] https://lore.kernel.org/all/20230220023320.3499-1-clin@suse.com/
Changes in v2: - Use of_device_get_match_data() to get matched of_device_id data. - Enhance sizeof() arguments. - Fix blanks and remove unnecessary parentheses. - Drop unnecessary marcos and s32_pin_config() implemented in v1 and set/clear mask/config values transparently. - Put pull-function related cases together in s32_pin_set_pull(). - Simply use generic 'struct pinfunction' rather than having extra 'struct s32_pmx_func'.
Chester Lin (4): pinctrl: s32: use of_device_get_match_data() to get device data pinctrl: s32: refine error/return/config checks and simplify driver codes pinctrl: s32cc: refactor pin config parsing pinctrl: s32cc: embed generic struct pingroup and pinfunction
drivers/pinctrl/nxp/pinctrl-s32.h | 26 +-- drivers/pinctrl/nxp/pinctrl-s32cc.c | 261 +++++++++++++++------------- drivers/pinctrl/nxp/pinctrl-s32g2.c | 14 +- 3 files changed, 152 insertions(+), 149 deletions(-)
-- 2.37.3
| |