Messages in this thread | | | Date | Fri, 3 Mar 2023 08:19:36 +0800 | From | kernel test robot <> | Subject | Re: [PATCH printk v1 10/18] printk: nobkl: Add emit function and callback functions for atomic printing |
| |
Hi John,
I love your patch! Perhaps something to improve:
[auto build test WARNING on 10d639febe5629687dac17c4a7500a96537ce11a]
url: https://github.com/intel-lab-lkp/linux/commits/John-Ogness/kdb-do-not-assume-write-callback-available/20230303-040039 base: 10d639febe5629687dac17c4a7500a96537ce11a patch link: https://lore.kernel.org/r/20230302195618.156940-11-john.ogness%40linutronix.de patch subject: [PATCH printk v1 10/18] printk: nobkl: Add emit function and callback functions for atomic printing config: nios2-buildonly-randconfig-r004-20230302 (https://download.01.org/0day-ci/archive/20230303/202303030859.j7DLimWU-lkp@intel.com/config) compiler: nios2-linux-gcc (GCC) 12.1.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/cae46beabb2dfe79a4c4c602601fa538a8d840f7 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review John-Ogness/kdb-do-not-assume-write-callback-available/20230303-040039 git checkout cae46beabb2dfe79a4c4c602601fa538a8d840f7 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=nios2 olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=nios2 SHELL=/bin/bash kernel/printk/
If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot <lkp@intel.com> | Link: https://lore.kernel.org/oe-kbuild-all/202303030859.j7DLimWU-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> kernel/printk/printk.c:2841:6: warning: no previous prototype for 'printk_get_next_message' [-Wmissing-prototypes] 2841 | bool printk_get_next_message(struct printk_message *pmsg, u64 seq, | ^~~~~~~~~~~~~~~~~~~~~~~
vim +/printk_get_next_message +2841 kernel/printk/printk.c
2821 2822 /* 2823 * Read and format the specified record (or a later record if the specified 2824 * record is not available). 2825 * 2826 * @pmsg will contain the formatted result. @pmsg->pbufs must point to a 2827 * struct printk_buffers. 2828 * 2829 * @seq is the record to read and format. If it is not available, the next 2830 * valid record is read. 2831 * 2832 * @is_extended specifies if the message should be formatted for extended 2833 * console output. 2834 * 2835 * @may_supress specifies if records may be skipped based on loglevel. 2836 * 2837 * Returns false if no record is available. Otherwise true and all fields 2838 * of @pmsg are valid. (See the documentation of struct printk_message 2839 * for information about the @pmsg fields.) 2840 */ > 2841 bool printk_get_next_message(struct printk_message *pmsg, u64 seq, 2842 bool is_extended, bool may_suppress) 2843 { 2844 static int panic_console_dropped; 2845 2846 struct printk_buffers *pbufs = pmsg->pbufs; 2847 const size_t scratchbuf_sz = sizeof(pbufs->scratchbuf); 2848 const size_t outbuf_sz = sizeof(pbufs->outbuf); 2849 char *scratchbuf = &pbufs->scratchbuf[0]; 2850 char *outbuf = &pbufs->outbuf[0]; 2851 struct printk_info info; 2852 struct printk_record r; 2853 size_t len = 0; 2854 2855 /* 2856 * Formatting extended messages requires a separate buffer, so use the 2857 * scratch buffer to read in the ringbuffer text. 2858 * 2859 * Formatting normal messages is done in-place, so read the ringbuffer 2860 * text directly into the output buffer. 2861 */ 2862 if (is_extended) 2863 prb_rec_init_rd(&r, &info, scratchbuf, scratchbuf_sz); 2864 else 2865 prb_rec_init_rd(&r, &info, outbuf, outbuf_sz); 2866 2867 if (!prb_read_valid(prb, seq, &r)) 2868 return false; 2869 2870 pmsg->seq = r.info->seq; 2871 pmsg->dropped = r.info->seq - seq; 2872 2873 /* 2874 * Check for dropped messages in panic here so that printk 2875 * suppression can occur as early as possible if necessary. 2876 */ 2877 if (pmsg->dropped && 2878 panic_in_progress() && 2879 panic_console_dropped++ > 10) { 2880 suppress_panic_printk = 1; 2881 pr_warn_once("Too many dropped messages. Suppress messages on non-panic CPUs to prevent livelock.\n"); 2882 } 2883 2884 /* Skip record that has level above the console loglevel. */ 2885 if (may_suppress && suppress_message_printing(r.info->level)) 2886 goto out; 2887 2888 if (is_extended) { 2889 len = info_print_ext_header(outbuf, outbuf_sz, r.info); 2890 len += msg_print_ext_body(outbuf + len, outbuf_sz - len, 2891 &r.text_buf[0], r.info->text_len, &r.info->dev_info); 2892 } else { 2893 len = record_print_text(&r, console_msg_format & MSG_FORMAT_SYSLOG, printk_time); 2894 } 2895 out: 2896 pmsg->outbuf_len = len; 2897 return true; 2898 } 2899
-- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests
| |