lkml.org 
[lkml]   [2023]   [Mar]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH printk v1 01/18] kdb: do not assume write() callback available
    On Thu, Mar 09, 2023 at 12:26:23PM +0100, Petr Mladek wrote:
    > On Thu 2023-03-09 10:52:40, Daniel Thompson wrote:
    > > On Thu, Mar 02, 2023 at 09:02:01PM +0106, John Ogness wrote:
    > > > It is allowed for consoles to provide no write() callback. For
    > > > example ttynull does this.
    > > >
    > > > Check if a write() callback is available before using it.
    > > >
    > > > Signed-off-by: John Ogness <john.ogness@linutronix.de>
    > >
    > > Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
    > >
    > > Any thoughts on best way to land the series. All via one tree or can
    > > we pick and mix?
    >
    > I would prefer to take everything via the printk tree because
    > most changes are there. Otherwise, we might end up with non-necessary
    > cross-tree merge conflicts. Also I would know when all pieces are
    > there.
    >
    > That said, this seems to be the only change in
    > kernel/debug/kdb/kdb_io.c and it is relatively independent.
    > So, it should not be a big problem to take it separately.

    Enthusiastically
    Acked-by: Daniel Thompson <daniel.thompson@linaro.org>

    That suits me fine: kgdb is pretty quiet at the moment so, whilst I
    can't predict what patches will show up this cycle, this probably spares
    me from having to put together a PR for a single patch!


    Daniel.

    \
     
     \ /
      Last update: 2023-03-27 00:51    [W:3.363 / U:0.336 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site