Messages in this thread | | | Date | Sun, 19 Mar 2023 22:46:56 +0800 | From | kernel test robot <> | Subject | arch/riscv/include/asm/atomic.h:317 arch_atomic_dec_if_positive() warn: inconsistent indenting |
| |
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: a3671bd86a9770e34969522d29bb30a1b66fd88a commit: 1d7f6932c522ea95668e14265175ce3d753d0c24 riscv: atomic: Optimize dec_if_positive functions date: 10 months ago config: riscv-randconfig-m031-20230319 (https://download.01.org/0day-ci/archive/20230319/202303192200.CcBA7bZy-lkp@intel.com/config) compiler: riscv32-linux-gcc (GCC) 12.1.0
If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot <lkp@intel.com> | Link: https://lore.kernel.org/oe-kbuild-all/202303192200.CcBA7bZy-lkp@intel.com/
New smatch warnings: arch/riscv/include/asm/atomic.h:317 arch_atomic_dec_if_positive() warn: inconsistent indenting arch/riscv/include/asm/atomic.h:317 arch_atomic_dec_if_positive() warn: inconsistent indenting
Old smatch warnings: drivers/block/mtip32xx/mtip32xx.c:2264 mtip_hw_read_device_status() warn: check sign expansion for 'size' drivers/block/mtip32xx/mtip32xx.c:2328 mtip_hw_read_registers() warn: check sign expansion for 'size' drivers/block/mtip32xx/mtip32xx.c:3638 mtip_block_initialize() warn: missing error code? 'rv' drivers/block/mtip32xx/mtip32xx.c:4131 mtip_pci_remove() warn: '&dd->remove_list' not removed from list
vim +317 arch/riscv/include/asm/atomic.h
fab957c11efe2f Palmer Dabbelt 2017-07-10 312 1d7f6932c522ea Guo Ren 2022-05-05 313 static __always_inline int arch_atomic_dec_if_positive(atomic_t *v) fab957c11efe2f Palmer Dabbelt 2017-07-10 314 { fab957c11efe2f Palmer Dabbelt 2017-07-10 315 int prev, rc; fab957c11efe2f Palmer Dabbelt 2017-07-10 316 fab957c11efe2f Palmer Dabbelt 2017-07-10 @317 __asm__ __volatile__ ( 5ce6c1f3535fa8 Andrea Parri 2018-03-09 318 "0: lr.w %[p], %[c]\n" 1d7f6932c522ea Guo Ren 2022-05-05 319 " addi %[rc], %[p], -1\n" 5ce6c1f3535fa8 Andrea Parri 2018-03-09 320 " bltz %[rc], 1f\n" 5ce6c1f3535fa8 Andrea Parri 2018-03-09 321 " sc.w.rl %[rc], %[rc], %[c]\n" 5ce6c1f3535fa8 Andrea Parri 2018-03-09 322 " bnez %[rc], 0b\n" 5ce6c1f3535fa8 Andrea Parri 2018-03-09 323 " fence rw, rw\n" 5ce6c1f3535fa8 Andrea Parri 2018-03-09 324 "1:\n" fab957c11efe2f Palmer Dabbelt 2017-07-10 325 : [p]"=&r" (prev), [rc]"=&r" (rc), [c]"+A" (v->counter) 1d7f6932c522ea Guo Ren 2022-05-05 326 : fab957c11efe2f Palmer Dabbelt 2017-07-10 327 : "memory"); 1d7f6932c522ea Guo Ren 2022-05-05 328 return prev - 1; fab957c11efe2f Palmer Dabbelt 2017-07-10 329 } fab957c11efe2f Palmer Dabbelt 2017-07-10 330
:::::: The code at line 317 was first introduced by commit :::::: fab957c11efe2f405e08b9f0d080524bc2631428 RISC-V: Atomic and Locking Code
:::::: TO: Palmer Dabbelt <palmer@dabbelt.com> :::::: CC: Palmer Dabbelt <palmer@dabbelt.com>
-- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests
| |