Messages in this thread Patch in this message | | | Subject | Re: [PATCH 37/37] drm/bridge/imx/Kconfig: Prevent imx-ldb-helper from appearing in 2 separate modules | From | Liu Ying <> | Date | Fri, 17 Mar 2023 17:42:21 +0800 |
| |
Hi Lee,
On Fri, 2023-03-17 at 08:17 +0000, Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > scripts/Makefile.build:252: drivers/gpu/drm/bridge/imx/Makefile: imx-ldb-helper.o is added to multiple modules: imx8qm-ldb imx8qxp-ldb > > Cc: Liu Ying <victor.liu@nxp.com> > Cc: Andrzej Hajda <andrzej.hajda@intel.com> > Cc: Neil Armstrong <neil.armstrong@linaro.org> > Cc: Robert Foss <rfoss@kernel.org> > Cc: Laurent Pinchart <Laurent.pinchart@ideasonboard.com> > Cc: Jonas Karlman <jonas@kwiboo.se> > Cc: Jernej Skrabec <jernej.skrabec@gmail.com> > Cc: David Airlie <airlied@gmail.com> > Cc: Daniel Vetter <daniel@ffwll.ch> > Cc: Shawn Guo <shawnguo@kernel.org> > Cc: Sascha Hauer <s.hauer@pengutronix.de> > Cc: Pengutronix Kernel Team <kernel@pengutronix.de> > Cc: Fabio Estevam <festevam@gmail.com> > Cc: NXP Linux Team <linux-imx@nxp.com> > Cc: dri-devel@lists.freedesktop.org > Cc: linux-arm-kernel@lists.infradead.org > Signed-off-by: Lee Jones <lee@kernel.org>
Thank you for the patch.
> --- > drivers/gpu/drm/bridge/imx/Kconfig | 7 +++++++ > drivers/gpu/drm/bridge/imx/Makefile | 7 +++++-- > drivers/gpu/drm/bridge/imx/imx-ldb-helper.c | 13 +++++++++++++ > 3 files changed, 25 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/imx/Kconfig b/drivers/gpu/drm/bridge/imx/Kconfig > index 608f47f41bcd1..97018dcd078d0 100644 > --- a/drivers/gpu/drm/bridge/imx/Kconfig > +++ b/drivers/gpu/drm/bridge/imx/Kconfig > @@ -1,10 +1,16 @@ > if ARCH_MXC || COMPILE_TEST > > +config DRM_IMX8_LIB
I would limit this to i.MX LVDS Display Bridge(LDB) library, so I suggest to use DRM_IMX_LDB_LIB.
> + tristate > + help > + Common helper functions used by some of the drivers below.
Considering to use DRM_IMX_LDB_LIB, help message can be a bit more specific to LDB drivers, like:
Common helper functions used by i.MX LVDS display bridge drivers below.
Regards, Liu Ying
| |