lkml.org 
[lkml]   [2023]   [Mar]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH 15/37] drm/amd/amdgpu/gmc_v11_0: Provide a few missing param descriptions relating to hubs and flushes
    Applied.  Thanks!

    Alex

    On Fri, Mar 17, 2023 at 4:23 AM Lee Jones <lee@kernel.org> wrote:
    >
    > Fixes the following W=1 kernel build warning(s):
    >
    > drivers/gpu/drm/amd/amdgpu/gmc_v11_0.c:282: warning: Function parameter or member 'vmhub' not described in 'gmc_v11_0_flush_gpu_tlb'
    > drivers/gpu/drm/amd/amdgpu/gmc_v11_0.c:282: warning: Function parameter or member 'flush_type' not described in 'gmc_v11_0_flush_gpu_tlb'
    > drivers/gpu/drm/amd/amdgpu/gmc_v11_0.c:322: warning: Function parameter or member 'flush_type' not described in 'gmc_v11_0_flush_gpu_tlb_pasid'
    > drivers/gpu/drm/amd/amdgpu/gmc_v11_0.c:322: warning: Function parameter or member 'all_hub' not described in 'gmc_v11_0_flush_gpu_tlb_pasid'
    >
    > Cc: Alex Deucher <alexander.deucher@amd.com>
    > Cc: "Christian König" <christian.koenig@amd.com>
    > Cc: "Pan, Xinhui" <Xinhui.Pan@amd.com>
    > Cc: David Airlie <airlied@gmail.com>
    > Cc: Daniel Vetter <daniel@ffwll.ch>
    > Cc: amd-gfx@lists.freedesktop.org
    > Cc: dri-devel@lists.freedesktop.org
    > Signed-off-by: Lee Jones <lee@kernel.org>
    > ---
    > drivers/gpu/drm/amd/amdgpu/gmc_v11_0.c | 4 ++++
    > 1 file changed, 4 insertions(+)
    >
    > diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v11_0.c b/drivers/gpu/drm/amd/amdgpu/gmc_v11_0.c
    > index fad199ed15f38..9f4f28192c601 100644
    > --- a/drivers/gpu/drm/amd/amdgpu/gmc_v11_0.c
    > +++ b/drivers/gpu/drm/amd/amdgpu/gmc_v11_0.c
    > @@ -274,6 +274,8 @@ static void gmc_v11_0_flush_vm_hub(struct amdgpu_device *adev, uint32_t vmid,
    > *
    > * @adev: amdgpu_device pointer
    > * @vmid: vm instance to flush
    > + * @vmhub: which hub to flush
    > + * @flush_type: the flush type
    > *
    > * Flush the TLB for the requested page table.
    > */
    > @@ -313,6 +315,8 @@ static void gmc_v11_0_flush_gpu_tlb(struct amdgpu_device *adev, uint32_t vmid,
    > *
    > * @adev: amdgpu_device pointer
    > * @pasid: pasid to be flush
    > + * @flush_type: the flush type
    > + * @all_hub: flush all hubs
    > *
    > * Flush the TLB for the requested pasid.
    > */
    > --
    > 2.40.0.rc1.284.g88254d51c5-goog
    >

    \
     
     \ /
      Last update: 2023-03-27 01:06    [W:2.593 / U:0.240 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site